Basic: use .standardizingPath instead of realpath
#2288
Conversation
|
@swift-ci please smoke test |
This Foundation extension provides the same behaviour but is portable across different platforms.
compnerd
force-pushed
the
a-new-standard
branch
from
23ea1c2 to
ab6470b
Compare
|
@swift-ci please smoke test |
| } | ||
|
|
||
| return path | ||
| return AbsolutePath(path.pathString.resolvingSymlinksInPath) |
There was a problem hiding this comment.
I understand and support the motivation here, but I have some concerns about performance. For example, I think that the swift-corelibs-foundation implementation implements this by creating multiple URLs and breaking it into components. Would it be possible to conditionally keep the optimized implementation and use the more generic one only for platforms that don't support realpath()?
We should of course measure to see whether there's really a difference, but shouldn't make this change unless we know it doesn't slow down the current platforms.
There was a problem hiding this comment.
Just a curious onlooker here, but the Foundation API does exactly what this one is supposed to do, and if there are more optimal ways to get the result, that should be a Foundation-level optimisation which would benefit everybody, right?
|
Obsoleted by swiftlang/swift-tools-support-core#114 |
This Foundation extension provides the same behaviour but is portable
across different platforms.