Path: use isAbsolutePath instead of re-implenting
#2294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
This is needed to properly handle Windows paths which are not Unix-like. Absolute paths are spelt with a prefix of `\\` or `.:`. Rely on Foundation to provide sufficient abstraction for determining if the path is absolute.
compnerd
force-pushed
the
absolutely-unequivocally-absolute
branch
from
1490b8c to
9809ced
Compare
|
@swift-ci please smoke test |
aciidgh
reviewed
Aug 15, 2019
| case "~": | ||
| throw PathValidationError.startsWithTilde(path) | ||
| default: | ||
| throw PathValidationError.invalidAbsolutePath(path) | ||
| guard (path as NSString).isAbsolutePath else { |
There was a problem hiding this comment.
I am worried about the performance impact of this. Can we measure the difference or otherwise reimplement it Windows?
There was a problem hiding this comment.
Do you have an easy/automated way to test the performance impact?
There was a problem hiding this comment.
You can generate Xcode project with SwiftPM perf tests enabled using: Utilities/bootstrap --generate-xcodeproj --enable-perf-tests
Then add a perf test here and run using the PerformanceTest:
You can write a test here: https://github.com/apple/swift-package-manager/tree/master/Tests/BasicPerformanceTests
|
I think that this is obsoleted by swiftlang/swift-tools-support-core#114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to properly handle Windows paths which are not Unix-like.
Absolute paths are spelt with a prefix of
\\or.:. Rely onFoundation to provide sufficient abstraction for determining if the path
is absolute.