Add --release flag for bootstrap script #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
| @@ -648,7 +653,6 @@ def main(): | |||
|
|
|||
| swift_build_path = os.path.join(build_path, "debug", "swift-build") | |||
| swift_test_path = os.path.join(build_path, "debug", "swift-test") | |||
| note("built: %s" % (swift_build_path,)) | |||
There was a problem hiding this comment.
These paths aren't correct, and they are used in the testing step below...
Never mind, I see now that was fixed in the other commit.
There was a problem hiding this comment.
Yeah, sorry, I spotted it later though at least.
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
* Add file-system client config attribute support Allows setting 'device-agnostic' file system in the build file rdar://problem/37445150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the bootstrap script to build SwiftPM in release mode.
We need to add integration to the swift build-script so that we are built in release mode as part of snapshots.