Enable VT100 Sequences on Windows #2350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Windows doesn't interpret VT100 sequences. Previously: ``` ☐[31m☐[1merror: ☐[0munknown option --bin-path; use --help to list available options ``` Now (pretending error is in red): ``` error: unknown option --bin-path; use --help to list available options ```
gmittert
requested review from
abertelrud,
aciidgh and
neonichu
as code owners
|
Thanks! Is there an easy way to test this? |
aciidgh
approved these changes
Sep 24, 2019
I suppose a case that prints some text then checks the ConsoleMode might do it. However, I haven't got the tests working yet, so I wouldn't actually be able to check if the tests work... |
|
Cool, maybe we can add a test later. |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Windows doesn't interpret VT100 sequences.
Previously:
Now (pretending error is in red):