Skip to content

[Build] Add -gnu in x86_64 Linux's triple #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

aciidgh
Copy link
Contributor

@aciidgh aciidgh commented Sep 25, 2019

Absense of environment in the triple seems to cause issues during
debugging. Adding this to unblock my integration test but we should just
switch to asking clang for the host target triple using clang -print-target-triple.

Absense of environment in the triple seems to cause issues during
debugging. Adding this to unblock my integration test but we should just
switch to asking clang for the host target triple using `clang
-print-target-triple`.
@aciidgh
Copy link
Contributor Author

aciidgh commented Sep 25, 2019

Please test with following pull request:
swiftlang/swift-integration-tests#64

@swift-ci Please test

Copy link
Contributor

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ppc64le and arm64 should also have it, but that doesn't need to be done as part of this patch.

@aciidgh
Copy link
Contributor Author

aciidgh commented Sep 25, 2019

Please test with following pull request:
swiftlang/swift-integration-tests#64

@swift-ci please test linux

1 similar comment
@aciidgh
Copy link
Contributor Author

aciidgh commented Sep 26, 2019

Please test with following pull request:
swiftlang/swift-integration-tests#64

@swift-ci please test linux

@aciidgh aciidgh merged commit 128a793 into swiftlang:master Sep 28, 2019
@aciidgh aciidgh deleted the add-env-linux-x86-64 branch September 28, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants