Compile and Run the Manifest on Windows #2363
Conversation
The swift interpreter doesn't work on Windows currently. Instead of attempting to interpret the manifest, we compile it to a temporary file, then execute it.
gmittert
requested review from
abertelrud,
aciidgh and
neonichu
as code owners
| @@ -419,7 +419,11 @@ public final class ManifestLoader: ManifestLoaderProtocol { | |||
| } | |||
| #endif | |||
| cmd += [resources.swiftCompiler.pathString] | |||
| // The interpreter doesn't work on Windows yet, so instead | |||
| // we compile and run it on Windows | |||
| #if !os(Windows) | |||
There was a problem hiding this comment.
Do you know if it'll be available soon? I think we should break this into cleaner functions for compiling vs interpreting and then always select the compiling one for windows.
There was a problem hiding this comment.
I don't think anyone is working on it at the moment. I can split them out though, that makes sense to me.
There was a problem hiding this comment.
Using #if os(Windows) for this means the code is likely to break as others do refactoring an Darwin/Linux. Can it instead be some global Bool whose default value differs on Windows, but which will allow us to test the behavior on Darwin/Linux as well?
There was a problem hiding this comment.
That's the plan (see my first comment).
|
This should be no longer needed with #2518 Please open a new PR if some changes are still required for Windows support! |
The swift interpreter doesn't work on Windows currently. Instead of
attempting to interpret the manifest, we compile it to a temporary file,
then execute it.