[bootstrap] Fix Python 3 compatibility regression #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sigh, thanks! Any interest in writing an "integration-tests" test for this (https://github.com/apple/swift-integration-tests)? It could be conditional on the presence of Python3, and we could arrange for the CI to have it available on at least one platform (Linux probably) |
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
- This passed CI, but is causing some downstream problem.
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
aciidgh
pushed a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Jan 11, 2019
- This passed CI, but is causing some downstream problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new function introduced in 2ce8a18 has Python 2 syntax. The script had been Python 3 compatible up until then. This patch restores that compatibility.