Fix functional build tests for swiftpm target

[onevcat]

Problem

All of the FunctionalBuildTests is now failing when testing in Xcode with Cmd+U.

It seems that the executable file swift-build is placed under .build/.bootstrap/bin. At the same time, the Resources.computeResourcesPaths() is using "SPM_INSTALL_PATH" environment variable to search the built product. However, the install path is set to $(PROJECT_DIR)/../.build. This leads the correct executable could not be found and the default swift-build is returned.

So invoking of executeSwiftBuild(_:) will always fail if the swift-build could not be found in system search path. Even it is there, the executable might be an older one instead of newly built file. This might not be the expected behavior.

Fix

Simply changing the "SPM_INSTALL_PATH" from $(PROJECT_DIR)/../.build to $(PROJECT_DIR)/../.build/.bootstrap would solve it and make all tests green.

P.S.

Everything goes well when using bootstrap script.

./Utilities/bootstrap --build-tests test

Since the sandbox_path is set correctly.

sandbox_path = os.path.join(build_path, ".bootstrap")
# ...
env_cmd = ["env",
                   "SWIFTC=" + opts.swiftc_path,
                   "SWIFT_BUILD_TOOL=" + opts.sbt_path,
                   "SPM_INSTALL_PATH=" + sandbox_path]

[mxcl]

/cc @ddunbar

[mxcl]

Thanks, we have decided to instead add a symlink to debug as part of those dep’s test script phases because we want the second phase swift-build to run these tests rather than the bootstrapped swift-build.

[mxcl]

But thank you for the detailed report and the time you spent fixing it.