Conditional target dependencies manifest api #2425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartbit
changed the title
hartbit
force-pushed
the
conditional-target-dependencies-manifest-api
branch
3 times, most recently
from
037ad7c to
cdda7de
Compare
hartbit
changed the title
hartbit
force-pushed
the
conditional-target-dependencies-manifest-api
branch
3 times, most recently
from
13c666e to
dcd72d4
Compare
hartbit
force-pushed
the
conditional-target-dependencies-manifest-api
branch
from
dcd72d4 to
b426d12
Compare
|
Closing to have only one PR -> #2428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifest API changes to support a future conditional target dependencies evolution proposal.
BuildSettingsConditioninPackageDescription.ManifestConditionDescriptiontype to hold conditions in the manifestTarget.Dependencycases.BuildSettingsConditionand renamed it toManifestConditionto reflect its new status. Similarly, I movedPlatformsConditionandConfigurationConditioninto the global scope.I also took the opportunity to make small improvements to the code:
BuildEnvironmenttype to name the platform + config tuple.satisfies(_:)requirement to theManifestConditionprotocol to move the verification logic into each conforming type.Question: I wasn't sure if I could rename
BuildSettingsConditioninPackageDescriptionwithout breaking backwards compatibility, so I left it as-is for now.This PR is based on #2422, so it needs to be merged before this one.