Add support for the Scudo sanitizer. #2438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciidgh
approved these changes
Dec 9, 2019
Lukasa
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci please test |
|
I've brought this patch back up-to-date with |
The Swift PR swiftlang/swift#28538 adds support for the Scudo hardened allocator to swiftc. This patch adds support for it to Swift Package Manager, allowing the Package Manager to correctly plumb Scudo through the entire build pipeline. See the aforementioned PR for more discussion on the value of supporting Scudo.
|
@swift-ci please smoke test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
abertelrud
approved these changes
Apr 28, 2020
|
Merged. Please open a separate PR for the 5.3, which Rick (release manager for SwiftPM in 5.3) will need to approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift PR swiftlang/swift#28538 adds support for the Scudo hardened
allocator to swiftc. This patch adds support for it to Swift Package
Manager, allowing the Package Manager to correctly plumb Scudo through
the entire build pipeline.
See the aforementioned PR for more discussion on the value of supporting
Scudo.
Note that the tests will fail until swiftlang/swift#28538 lands.