build: add export targets #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
aciidgh
reviewed
Dec 10, 2019
aciidgh
reviewed
Dec 10, 2019
aciidgh
reviewed
Dec 10, 2019
This sets up the export targets for swift-package-manager to allow SourceKit-LSP to build against a local build of swift-package-manager on Windows.
compnerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
CC: @benlangmuir |
|
hi @compnerd is this still PR relevant? maybe for editing with LSP based editors? |
|
Yes, this is relevant for LSP. |
|
@swift-ci please test |
abertelrud
approved these changes
Aug 31, 2020
|
@swift-ci please smoke test |
|
Retested this, it works and enables SourceKit-LSP work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exports targets from SPM so that they can be used in SourceKit-LSP.