[test] Update PD5LoadingTests.swift for an upcoming parser fix that suppressed a diagnostic it was checking for. #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a diagnostic it was checking for.
The test parses the code below and checks for a "expected ')' in expression
list" diagnostic:
```
import PackageDescription
let package = Package(
name: "Trivial",
targets: [
.target(
name: "foo",
dependencies: []),
)
```
Prior to the parser fix the invalid collection literal failed to parse but the
error status wasn't propagated up to the containing argument list parsing code,
so it produced an additional (and undesirable) missing right token diagnostic
that this test was checking for.
/tmp/t.swift:9:1: error: expected expression in container literal
)
^
/tmp/t.swift:9:2: error: expected ')' in expression list
)
^
/tmp/t.swift:2:22: note: to match this opening '('
let package = Package(
^
Afer the parser fix in swiftlang/swift#30187, we only
report the first container literal error and suppress the rest:
/tmp/t.swift:9:1: error: expected expression in container literal
)
^
|
@swift-ci smoke test |
aciidgh
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test parses the code below and checks for a
expected ')' in expression listdiagnostic:Prior to the parser fix the invalid targets array literal failed to parse but the error status wasn't propagated up to the containing argument list parsing code, so it produced an additional (and undesirable) missing right token diagnostic that this test was checking for.
After the parser fix in swiftlang/swift#30187 lands, we will only report the first error and suppress the rest:
So this PR changes the test to check for that diagnostic instead.