Skip to content

Fix search for coverage tools on Windows & cleanup UserToolchain #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2020
Merged

Fix search for coverage tools on Windows & cleanup UserToolchain #2712

merged 2 commits into from
May 8, 2020

Conversation

egorzhdan
Copy link
Contributor

This PR contains a few minor changes to UserToolchain:

  • When searching for llvm-cov & llvm-profdata we should take the .exe suffix into account.
  • Compiler search on non-macOS used Foundation.FileManager instead of LocalFileSystem.
  • There were multiple ways to retrieve an executable by a tool name and validate it which caused some duplication.

@neonichu
Copy link
Contributor

@swift-ci please smoke test

@neonichu neonichu merged commit ffa477c into swiftlang:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonichu neonichu neonichu approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud

@aciidgh aciidgh Awaiting requested review from aciidgh

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorzhdan @neonichu