Skip to content

Update In-Source Documentation #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ElektrojungeAtWork
Copy link
Contributor

@ElektrojungeAtWork ElektrojungeAtWork commented Apr 28, 2020

This PR includes the following updates:

  • Fix a few typos.
  • Don't use title case for "Swift package manager".
  • Use Apple-style docs for abstracts, e.g. use 3rd person for verb phrases ("Creates..." instead of "Create").
  • Add source docs for package resources, localized resources, and binary packages.

@ElektrojungeAtWork
Copy link
Contributor Author

The recent updates address the feedback. I've removed references to XCFramework, and made sure we're using title case when referring to the SwiftPM.

@neonichu
Copy link
Contributor

neonichu commented May 4, 2020

@swift-ci please smoke test

@neonichu
Copy link
Contributor

neonichu commented May 4, 2020

Oh, just saw that this is targeting the release/5.3 branch, we need a corresponding PR to master first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants