Handle new Job.Kind.backend enum case from swift-driver #2761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci smoke test |
|
does the description of the job look ok? I'm not very familiar with -embed-bitcode |
neonichu
approved these changes
May 20, 2020
|
This looks good to me. Does this introduce a revlock on the compiler driver commit, or are we already in that situation? (and that's why the build failed?) |
abertelrud
approved these changes
May 20, 2020
|
Yah, we're already in the situation that building SwiftPM master fails with swift-driver master. |
|
Yep, just saw the failure in #2762 due to this, so we're already there. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new enum case was added to handle
-embed-bitcodein swiftlang/swift-driver#101 , this PR handles it in a couple switches to fix a compile error.