[Integrated driver] Adopt new driver APIs for descriptions. #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than letting the integrated Swift driver guess at where the Swift frontend is located, pass through the location of the Swift compiler. This also allows SWIFT_EXEC overrides to work with the integrated driver.
The Swift driver added some APIs to provide descriptions and whether a particular job invokes the Swift frontend. Use those APIs rather than switching on the "kind" of a Swift driver job.
DougGregor
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift driver added some APIs to provide descriptions and
whether a particular job invokes the Swift frontend. Use those
APIs rather than switching on the "kind" of a Swift driver job.