Don't pass / as default sysroot on Linux #2797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing / as sysroot breaks usage of toolchains installed in custom locations.
|
@swift-ci smoke test |
|
This looks right to me, but tagging @aciidb0mb3r to see if there were any reasons for passing |
|
I don’t remember unfortunately but it seems right to not pass it. |
jakepetroules
approved these changes
Jul 2, 2020
finagolfin
added a commit
to finagolfin/swift-package-manager
that referenced
this pull request
Jul 12, 2020
Instead, use swiftlang#2797, which made the SDK path optional, and simply pass nil by default as on linux.
neonichu
pushed a commit
that referenced
this pull request
Jul 15, 2020
Instead, use #2797, which made the SDK path optional, and simply pass nil by default as on linux.
artemcm
pushed a commit
to artemcm/swift-package-manager
that referenced
this pull request
Jul 29, 2020
Instead, use swiftlang#2797, which made the SDK path optional, and simply pass nil by default as on linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing / as sysroot breaks usage of toolchains installed in custom locations.