Add an option to output a dot graph of the build manifest. #2803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci smoke test |
abertelrud
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
This is great. Just a suggestion that when appropriate, when adding debugging support like this, it would be great to do it in a way that could also be enabled from IDEs such as Xcode (e.g. by being able to write to a general file or stream and not just stdout, etc).
| @@ -103,6 +103,9 @@ public class ToolOptions { | |||
| /// Whether to use the explicit module build flow (with the integrated driver) | |||
| public var useExplicitModuleBuild: Bool = false | |||
|
|
|||
| /// Whether to output a graphviz file visualization of the combined job graph for all targets | |||
| public var printManifestGraphviz: Bool = false | |||
There was a problem hiding this comment.
It would be great if this were phrased as the stream to which to write the GraphViz representation, rather than always writing it to stdout. That way we could enable it from IDEs such as Xcode, where emitting to stdout isn't always the right thing. This could be done as a follow-on PR.
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to how swift-driver can serialize Jobs for a given compilation target, add a capability to write out the entire build manifest as a dot graph.
This was extremely useful for debugging various build issues.