[Explicit Module Builds] Avoid adding cross-target input dependencies to intermediate build artifact jobs. #2804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci smoke test |
DougGregor
approved these changes
Jul 6, 2020
Sources/Build/ManifestBuilder.swift
Outdated
| // common intermediate dependency modules, such dependencies can lead | ||
| // to cycles in the resulting manifest. | ||
| var manifestNodeInputs = jobInputs | ||
| if !job.inputs.contains(where: { $0.type == .swiftInterface }) && |
There was a problem hiding this comment.
Should this predicate be given a name and sunk into swift-driver itself?
There was a problem hiding this comment.
Yeah, that's a good idea.
… to intermediate build artifact jobs. For a given target, in the Explicit Module Build world, swift-driver produces jobs to build the main module and jobs to build all module dependencies. cross-target dependencies should be added as explicit inputs to a target's main module build job, but not intermediate build dependency jobs. Always adding cross-target dependencies as inputs can lead to cycles in the build manifest when multiple targets share common intermediate module dependencies.
artemcm
force-pushed
the
ExplicitBuildCycles
branch
from
4eb57e1 to
2dd4dfc
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a given target, in the Explicit Module Build world,
swift-driverproduces jobs to build the main module and jobs to build all module dependencies.Cross-target dependencies should be added as explicit inputs to a target's main module build job, but not intermediate build dependency jobs.
Always adding cross-target dependencies as inputs can lead to cycles in the build manifest when multiple targets share common intermediate module dependencies.