Extend binary target tests to multiple arches #2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In swiftlang#2812, I updated the logic to support other architectures than just x86_64, but I did not update the tests. This extends the existing `testBinaryTargets` with the missing coverage.
neonichu
requested review from
abertelrud,
aciidgh and
friedbunny
as code owners
|
@swift-ci please smoke test |
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Jul 28, 2020
In swiftlang#2812, I updated the logic to support other architectures than just x86_64, but I did not update the tests. This extends the existing `testBinaryTargets` with the missing coverage. (cherry picked from commit c6ec2b4)
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Jul 28, 2020
In swiftlang#2812, I updated the logic to support other architectures than just x86_64, but I did not update the tests. This extends the existing `testBinaryTargets` with the missing coverage. (cherry picked from commit c6ec2b4)
neonichu
added a commit
that referenced
this pull request
Jul 28, 2020
* Update XCFramework logic This hardcoded platform and architectures before, make it mor generic to handle macOS on arm64. (cherry picked from commit f204c90) * Extend binary target tests to multiple arches (#2831) In #2812, I updated the logic to support other architectures than just x86_64, but I did not update the tests. This extends the existing `testBinaryTargets` with the missing coverage. (cherry picked from commit c6ec2b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2812, I updated the logic to support other architectures than just x86_64, but I did not update the tests. This extends the existing
testBinaryTargetswith the missing coverage.