[PackageLoading] Use a simpler manifest cache #2840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciidgh
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
|
@swift-ci smoke test |
|
Thanks for this simplification — I think it's great to reduce the complexity here! I don't see any aging of entries from the database, though — what's the strategy for preventing unbounded growth? |
|
I am considering cache eviction orthogonal since we don’t have that today either but it should be easy to do something since we now have full control over the cache. |
|
@swift-ci smoke test self hosted |
aciidgh
force-pushed
the
manifest-cache
branch
2 times, most recently
from
0b39c8b to
c528c32
Compare
|
@swift-ci smoke test self hosted |
|
@swift-ci smoke test |
This switches the manifest cache approach used inside manifest loader to directly use sqlite database instead of going through llbuild. The main reason for this switch is to simplify caching behavior and take advantage of SQLite's WAL mode for concurrent access. A separate PR will make the manifest cache global for the user.
|
@swift-ci smoke test |
neonichu
approved these changes
Aug 3, 2020
abertelrud
approved these changes
Aug 4, 2020
aciidgh
added a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Aug 27, 2020
This reverts commit 13d60ca.
aciidgh
added a commit
to aciidgh/swift-package-manager
that referenced
this pull request
Aug 27, 2020
This reverts commit 13d60ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the manifest cache approach used inside manifest loader to
directly use sqlite database instead of going through llbuild. The main
reason for this switch is to simplify caching behavior and take
advantage of SQLite's WAL mode for concurrent access. A separate PR will
make the manifest cache global for the user.