Improve check for unsafe flags #2845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciidgh
reviewed
Aug 4, 2020
| @@ -570,8 +570,11 @@ private final class ResolvedTargetBuilder: ResolvedBuilder<ResolvedTarget> { | |||
| } | |||
|
|
|||
| func diagnoseInvalidUseOfUnsafeFlags(_ product: ResolvedProduct) { | |||
| let inputTargets = product.targets | |||
| let recursiveDependencies = inputTargets.lazy.flatMap { $0.recursiveDependencies() } | |||
There was a problem hiding this comment.
I think this should be recursiveTargetDependencies
tomerd
approved these changes
Aug 4, 2020
tomerd
approved these changes
Aug 4, 2020
| @@ -570,8 +570,11 @@ private final class ResolvedTargetBuilder: ResolvedBuilder<ResolvedTarget> { | |||
| } | |||
|
|
|||
| func diagnoseInvalidUseOfUnsafeFlags(_ product: ResolvedProduct) { | |||
| let inputTargets = product.targets | |||
| let recursiveDependencies = inputTargets.lazy.flatMap { $0.recursiveDependencies() } | |||
| let reachableTargets = Set(inputTargets).union(recursiveDependencies.compactMap { $0.target }) | |||
There was a problem hiding this comment.
maybe worth making this a property of product rather than a local thing
There was a problem hiding this comment.
We already have recursiveTargetDependencies computed property as commented above
There was a problem hiding this comment.
nice. your comment above sounded like you wanted the variable to renamed
We prohibit unsafe flags in package dependencies, but the check was only looking at targets which are direct dependencies of a product, not transitive ones. rdar://problem/66499615
neonichu
force-pushed
the
handle-unsafe-flags-in-transitive-targets
branch
from
5389245 to
b9fcfa4
Compare
|
@swift-ci please smoke test |
|
Looks like this ran into the known module cache issue. |
|
@swift-ci please smoke test |
aciidgh
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prohibit unsafe flags in package dependencies, but the check was only looking at targets which are direct dependencies of a product, not transitive ones.
rdar://problem/66499615