Skip to content

Reinstate manifest sandboxing #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2020
Merged

Reinstate manifest sandboxing #2852

merged 1 commit into from
Aug 7, 2020

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Aug 6, 2020

5.3 cherry-pick of #2848

@neonichu
Reinstate manifest sandboxing
0f83b03 
Manifest loading has been sandboxed on macOS for a while, but the change
in swiftlang#2518 broke it for 5.3.

https://bugs.swift.org/browse/SR-13346
rdar://problem/66586184

(cherry picked from commit 4d720d6)
@neonichu neonichu requested review from tomerd and rballard August 6, 2020 20:26
@neonichu
Copy link
Contributor Author

neonichu commented Aug 6, 2020

@swift-ci please test

tomerd
tomerd approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@tomerd tomerd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but lets get rick and ankit to also take a look - specifically this also moved some perms outside the condition

@neonichu
Copy link
Contributor Author

neonichu commented Aug 6, 2020

java.io.EOFException 😆

@neonichu
Copy link
Contributor Author

neonichu commented Aug 6, 2020

Ankit approved the original already, #2848.

@neonichu
Copy link
Contributor Author

neonichu commented Aug 6, 2020

@swift-ci please test

@neonichu
Copy link
Contributor Author

neonichu commented Aug 6, 2020 •
edited
Loading 

15:24:55         @usableFromInline
15:24:55         ^~~~~~~~~~~~~~~~~
15:24:55         
15:24:55 /Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx/swift/stdlib/public/Darwin/Foundation/JSONEncoder.swift:926:39: warning: cast from 'Encodable' to unrelated type '[String : Encodable]' always fails
15:24:55             return try self.box(value as! [String : Encodable])
15:24:55                                 ~~~~~ ^   ~~~~~~~~~~~~~~~~~~~~
15:26:04 FATAL: command execution failed

That seems like an unrelated issue in Foundation.

@neonichu
Copy link
Contributor Author

neonichu commented Aug 6, 2020

@swift-ci please test

@neonichu
Copy link
Contributor Author

neonichu commented Aug 6, 2020

/home/buildnode/jenkins/workspace/swift-package-manager-PR-Linux/swift-corelibs-libdispatch/src/swift/Dispatch.swift:13:19: error: no such module 'Dispatch'

@neonichu
Copy link
Contributor Author

neonichu commented Aug 6, 2020

@swift-ci please test linux

@neonichu
Copy link
Contributor Author

neonichu commented Aug 7, 2020

Will need approval from @rballard to land.

@neonichu neonichu merged commit c131bec into swiftlang:release/5.3 Aug 7, 2020
@neonichu neonichu deleted the reinstate-manifest-sandboxing branch August 7, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@rballard rballard rballard approved these changes

@abertelrud abertelrud Awaiting requested review from abertelrud abertelrud is a code owner

@aciidgh aciidgh Awaiting requested review from aciidgh

@friedbunny friedbunny Awaiting requested review from friedbunny friedbunny is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonichu @tomerd @rballard