Allow SwiftCompilerMessages with no outputs #2854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift frontend jobs are not required to have outputs. When they don’t, there is no “output” field in the driver’s JSON. SwiftPM previously assumed an “output” field must be present; this commit disabuses it of that notion.
beccadax
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please test |
|
@swift-ci please smoke test |
neonichu
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift frontend jobs are not required to have outputs. When they don’t, there is no “output” field in the driver’s JSON. SwiftPM previously assumed an “output” field must be present; this commit disabuses it of that notion.
(Necessary for swiftlang/swift#33114; previously, the Swift driver never happened to do this for the compiles SwiftPM requested.)