Commands: remove signalled cases for Windows
#2855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not have the concept of signals, therefore processes may not terminate with signalling exits. Such an exit is encoded in the exit status code on Windows.
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please test |
|
code looks fine, but do we need to emit the text for the exit code instead? |
|
Yeah, I expect that we will have to wire that up in the future. This won't even build as there is no concept of signals, so this is purely to get s-p-m to build on Windows. |
|
@swift-ci please smoke test |
neonichu
approved these changes
Aug 17, 2020
abertelrud
approved these changes
Aug 17, 2020
|
@compnerd please merge when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not have the concept of signals, therefore processes may
not terminate with signalling exits. Such an exit is encoded in the
exit status code on Windows.