Workspace: assume that the user is always correct #2858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user specifies the Swift executable via `SWIFT_EXEC` in the environment, assume that the value is supposed to be used. This changes the order in which the Swift compiler is evaluated as being present. This can avoid an unnecessary lookup for the executable in the case that it is specified by the user.
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please test |
|
makes sense to me, but lets see what other thinks since I dont have the background on why it was done this way originally |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
neonichu
approved these changes
Aug 17, 2020
abertelrud
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
I don't have any context about why the code was the way it originally was, but the new order is conceptually correct as far as I'm concerned. It matches what similar tools in the ecosystem already do (e.g. Xcode's build settings for controlling paths of binaries etc).
|
@compnerd please merge when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user specifies the Swift executable via
SWIFT_EXECin theenvironment, assume that the value is supposed to be used. This changes
the order in which the Swift compiler is evaluated as being present.
This can avoid an unnecessary lookup for the executable in the case that
it is specified by the user.