Build fat when CROSS_COMPILE_HOSTS is set
#2859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts to building SwiftPM fat specifically when the build is happening on an Intel host and cross-compile host is set to "macosx-arm64".
neonichu
requested review from
abertelrud,
friedbunny and
rballard
as code owners
|
@swift-ci please test |
jakepetroules
approved these changes
Aug 11, 2020
rballard
approved these changes
Aug 11, 2020
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Aug 27, 2020
This adjusts to building SwiftPM fat specifically when the build is happening on an Intel host and cross-compile host is set to "macosx-arm64". (cherry picked from commit 6306663)
neonichu
added a commit
that referenced
this pull request
Aug 28, 2020
This adjusts to building SwiftPM fat specifically when the build is happening on an Intel host and cross-compile host is set to "macosx-arm64". (cherry picked from commit 6306663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts to building SwiftPM fat specifically when the build is happening on an Intel host and cross-compile host is set to "macosx-arm64".
I am intentionally not making a master PR first, because cherry-picking wouldn't merge cleanly and also building for multiple arches seems to be broken in master.