Symlink swift-autolink-extract into the SPM build dir #2871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
owenv
changed the title
|
swiftlang/swift-driver#208 |
|
cc @DougGregor & @artemcm |
DougGregor
approved these changes
Aug 17, 2020
|
@DougGregor lgtm merge when ready |
|
@DougGregor right now the bootstrap script only accepts |
|
Okay! Let's go ahead and merge this |
|
@DougGregor do you mind merging this on my behalf? I don't have write access to this repo |
|
Sure, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the integrated swift-driver, SPM may need to look up swift-autolink-extract. Symlinking it into the build dir alongside
swiftandswiftcprevents some test failures caused by swiftlang/swift-driver#208 (which fixes generation of autolink-extract jobs on linux)