Skip to content

Use .none as the default test specification #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Use .none as the default test specification #2893

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sources/Commands/SwiftTestTool.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,13 @@ struct TestToolOptions: ParsableArguments {

var testCaseSkip: TestCaseSpecifier {
// TODO: Remove this once the environment variable is no longer used.
testCaseSkipOverride() ?? .skip(_testCaseSkip)
if let override = testCaseSkipOverride() {
return override
}

return _testCaseSkip.isEmpty
? .none
: .skip(_testCaseSkip)
}

@Option(name: .customLong("skip"),
Expand Down