Skip to content

--skip-integrated-driver-tests should be a test argument #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2020
Merged

--skip-integrated-driver-tests should be a test argument #2894

merged 1 commit into from
Aug 28, 2020

Conversation

neonichu
Copy link
Contributor

I accidentally added it as a build argument.

@neonichu
--skip-integrated-driver-tests should be a test argument
351d314 
I accidentally added it as a build argument.
@neonichu
Copy link
Contributor Author

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

@swift-ci please smoke test macOS

@neonichu
Copy link
Contributor Author

/Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx-smoke-test/branch-master/swiftpm/Tests/FunctionalTests/MiscellaneousTests.swift:232: error: -[FunctionalTests.MiscellaneousTestCase testSwiftTestParallel] : XCTAssertTrue failed
17:31:39 /Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx-smoke-test/branch-master/swiftpm/Tests/FunctionalTests/MiscellaneousTests.swift:233: error: -[FunctionalTests.MiscellaneousTestCase testSwiftTestParallel] : XCTAssertTrue failed
17:31:39 /Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx-smoke-test/branch-master/swiftpm/Tests/FunctionalTests/MiscellaneousTests.swift:235: error: -[FunctionalTests.MiscellaneousTestCase testSwiftTestParallel] : XCTAssertTrue failed
17:31:39 /Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx-smoke-test/branch-master/swiftpm/Tests/FunctionalTests/MiscellaneousTests.swift:236: error: -[FunctionalTests.MiscellaneousTestCase testSwiftTestParallel] : XCTAssertTrue failed
17:31:39 Test Case '-[FunctionalTests.MiscellaneousTestCase testSwiftTestParallel]' failed (32.751 seconds).

@neonichu
Copy link
Contributor Author

I think that's a known flaky test.

@neonichu
Copy link
Contributor Author

@swift-ci please smoke test macOS

@neonichu neonichu merged commit 96b0ff9 into swiftlang:master Aug 28, 2020
@neonichu neonichu deleted the move-skip-arg branch August 28, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abertelrud abertelrud Awaiting requested review from abertelrud

@aciidgh aciidgh Awaiting requested review from aciidgh

@friedbunny friedbunny Awaiting requested review from friedbunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@neonichu