Skip to content

[bootstrap] Add support for cross compile hosts flag #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

shahmishal
Copy link
Member

No description provided.

@shahmishal
Copy link
Member Author

@swift-ci smoke test

@shahmishal
Copy link
Member Author

cc: @neonichu

@finagolfin
Copy link
Member

Interesting, @neonichu, I have a patch that I use to cross-compile SPM itself from linux x86_64 to Android AArch64 by invoking SPM from an official build of Swift 5.2.5 for Ubuntu with a destination JSON file set up to use the Android NDK. Once this pull is in, would you be interested in a pull that generalized that patch and adapted it to this new flag?

Copy link
Contributor

@abertelrud abertelrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Seems that it is mainly replacing an env var with a flag. I don't suppose we need to have both, in case something is still setting the env var?

@neonichu
Copy link
Contributor

neonichu commented Sep 1, 2020

Don't think we need both, using an env var was just me misunderstanding swift's build-script

@shahmishal shahmishal merged commit 4b5d0a6 into master Sep 1, 2020
@shahmishal shahmishal deleted the shahmishal/new-cross-compile-flag branch September 1, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants