Added option to enable CMake Install #2907
Conversation
Since SwiftPM does its own installation using the bootstrap script, it hides the CMake install target to only be enabled on Windows which doesn't use the bootstrap script. But when bootstrapping using CMake on non Windows platforms, it would be nice to be able to enable them.
gmittert
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
Yep, I think @compnerd mentioned that he also wanted this for the Windows port. (great branch name btw) |
|
macOS failure seems unrelated:
|
|
@swift-ci please smoke test macOS |
That sounds as if it could be related to recent argparser changes, but not sure why it wouldn't have shown up so far. |
|
Can definitely reproduce locally with @natecook1000 would you be able to take a look? |
|
I'm seeing this in https://github.com/apple/swift-package-manager/blob/master/Sources/Commands/SwiftPackageTool.swift#L543-L546 Quickest way to resolve is to version lock ArgumentParser at 0.3.0, but ultimately it'd be great to resolve that ambiguity (there are probably way too many things declared in |
Version 0.3.1+ triggers an assertion, so we pin the previous version until we can investigate this further. swiftlang#2907 (comment)
Version 0.3.1+ triggers an assertion, so we pin the previous version until we can investigate this further. #2907 (comment)
|
@swift-ci please smoke test |
Since SwiftPM does its own installation using the bootstrap script, it
hides the CMake install target to only be enabled on Windows which
doesn't use the bootstrap script. But when bootstrapping using CMake on
non Windows platforms, it would be nice to be able to enable them.