build: loosen swfit-argument-parser dependency #2912
Conversation
When building SourceKit-LSP without local deps, swift-argument-parser is taken to be 0.3.1..<0.4.0. However, swift-package-manager, a dependency of SourceKit-LSP requires =0.3.0. This results in a conflicting version statement that cannot be resolved. This only impacts the build in the non-local dependency situation which is why this probably hasn't been noticed.
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
Fix the version condition for swift-argument-parser
|
@swift-ci please smoke test |
|
swift-argument-parser was pinned to 0.3.0 in #2909 because version 0.3.1 triggers an assertion. That issue will need to be fixed before addressing this one |
|
@owenv thank you for pointing that out! That actually is very helpful. I think that the thing to do it to match SourceKit-LSP then to this I think. |
|
(converted to draft to prevent accidental merging) |
|
Amusingly enough, in that PR there was some discussion about whether we should have a comment in the package manifest to indicate why we were pinning to 0.3.0, but both Boris and I felt that maybe the commit log was enough. But I think in this case a comment right there in the manifest would probably have been helpful and saved some time, so I think we should do so in the future when we do something unusual in the manifest. |
|
BTW, I've created swiftlang/sourcekit-lsp#312 to sync SK-LSP with SPM |
When building SourceKit-LSP without local deps, swift-argument-parser is taken to be 0.3.1..<0.4.0. However, swift-package-manager, a dependency of SourceKit-LSP requires =0.3.0. This results in a conflicting version statement that cannot be resolved. This only impacts the build in the non-local dependency situation which is why this probably hasn't been noticed.