Enable testability if test discovery is enabled #2918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just makes XCBuild support match what we do in SwiftPM's own build system here: https://github.com/apple/swift-package-manager/blob/master/Sources/XCBuildSupport/PIFBuilder.swift#L308 We should probably revisit this behaviour, because this seems like a very confusing side effect on macOS where test discovery isn't even a thing, but right now we just want to match what the builtin build system does. (cherry picked from commit 57f9d0d)
neonichu
requested review from
abertelrud,
aciidgh and
friedbunny
as code owners
|
@swift-ci please smoke test |
|
Right, this does seem a bit odd. Is test discovery dependent on testability for technical reasons? |
abertelrud
approved these changes
Sep 10, 2020
I guess so, but since it isn't actually used today on macOS, it probably shouldn't affect the build there. It is also weird that this effectively means that |
|
Going to merge this to unblock master toolchain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just makes XCBuild support match what we do in SwiftPM's own build
system here: https://github.com/apple/swift-package-manager/blob/master/Sources/XCBuildSupport/PIFBuilder.swift#L308
We should probably revisit this behaviour, because this seems like a
very confusing side effect on macOS where test discovery isn't even a
thing, but right now we just want to match what the builtin build system
does.
(cherry picked from commit 57f9d0d)