[Integrated Swift driver] Handle derived source files in the integrated driver. #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed driver. - When computing command line arguments for the integrated driver invocation, append all source files, both user-written and derived. - When writing out an output file map, add derived source files and their build artifacts to it as well.
|
@swift-ci please smoke test |
artemcm
commented
Sep 19, 2020
| @@ -831,7 +831,7 @@ public final class SwiftTargetBuildDescription { | |||
| stream <<< " },\n" | |||
|
|
|||
| // Write out the entries for each source file. | |||
| let sources = target.sources.paths | |||
| let sources = target.sources.paths + derivedSources.paths | |||
| for (idx, source) in sources.enumerated() { | |||
| let object = objects[idx] | |||
There was a problem hiding this comment.
objects are formed by taking sources + derivedSources and adding a .o extension so this enumeration will still hold.
artemcm
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the [Implicit | Explicit] integrated driver flow ignores derived files when building a target and therefore is not able to handle targets with specified resource bundles, for example.