Make sure that a package location is associated with the diagnostics emitted from PackageBuilder for a particular package #2945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocation:)` closure that sets the package location. Without this, errors thrown for a package would be associated with a location, but regularly emitted diagnostics would not. The reason is that when the PackageBuilder is instantiated outside of the `diagnostics.with(location:)`, it keeps the unlocationed diagnostics engine as a property, and then uses that for all the diagnostics even though the `construct()` call happens inside of a with-location closure. This change allows all the diagnostics emitted by the PackageBuilder to be properly associated with the package.
abertelrud
requested review from
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
abertelrud
deleted the
eng/packagegraphloader-diagnostics-should-be-tagged-with-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the instantiation of PackageBuilder into the
diagnostics.with(location:)closure that sets the package location.Without this, errors thrown for a package would be associated with a location, but regularly emitted diagnostics would not. The reason is that when the PackageBuilder is instantiated outside of the
diagnostics.with(location:), it keeps the unlocationed diagnostics engine as a property, and then uses that for all the diagnostics even though theconstruct()call happens inside of a with-location closure.This change allows all the diagnostics emitted by the PackageBuilder to be properly associated with the package.
This also fixes a unit test that does not seem to have been testing the correct location to begin with.