Skip to content

Sync latest TSC changes from main #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Oct 6, 2020

No description provided.

@neonichu
Copy link
Contributor Author

neonichu commented Oct 6, 2020

@swift-ci please smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@neonichu
Copy link
Contributor Author

neonichu commented Oct 6, 2020

11:22:49 + git checkout master
11:22:49 error: pathspec 'master' did not match any file(s) known to git

I reached out to Mishal, since it seems like an infra issue.

@compnerd
Copy link
Member

compnerd commented Oct 6, 2020

Ah, yes, that is fallout of the branch renaming.

@neonichu
Copy link
Contributor Author

neonichu commented Oct 6, 2020

/Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx-smoke-test/branch-main/swiftpm/swift-tools-support-core/Sources/TSCBasic/Process.swift:354: error: -[TSCBasicTests.ProcessTests testStdin] : failed: caught error: "could not find executable for '/Users/buildnode/jenkins/workspace/swift-package-manager-PR-osx-smoke-test/branch-main/swiftpm/swift-tools-support-core/Tests/TSCBasicTests/processInputs/in-to-out'"

Looks like that's a new file I didn't add as part of the sync.

@neonichu
Copy link
Contributor Author

neonichu commented Oct 6, 2020

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Oct 6, 2020

Looks like SourceKit-LSP might need an update following the TSC change.

@compnerd
Copy link
Member

compnerd commented Oct 6, 2020

@neonichu swiftlang/sourcekit-lsp#325 should fix that (and is what uncovered this in the first place)

@compnerd
Copy link
Member

compnerd commented Oct 6, 2020

Please test with following PRs:
swiftlang/sourcekit-lsp#325

@swift-ci please smoke test

@compnerd
Copy link
Member

compnerd commented Oct 7, 2020

Please test with following PRs:
swiftlang/sourcekit-lsp#325

@swift-ci please smoke test

@neonichu
Copy link
Contributor Author

neonichu commented Oct 7, 2020

:0: error: PackageDescription4_2LoadingTests.testVersionSpecificLoading : threw error "invalidManifestFormat(":0: error: module file '/home/buildnode/.cache/clang/ModuleCache/1CE4HQWUXOEPN/SwiftGlibc-3BGMLFUATR4HM.pcm' is out of date and needs to be rebuilt: signature mismatch\n:0: note: imported by module 'SwiftOverlayShims' in '/home/buildnode/.cache/clang/ModuleCache/1CE4HQWUXOEPN/SwiftOverlayShims-28NZTBX7HPMYG.pcm'\n:0: error: missing required module 'SwiftOverlayShims'", diagnosticFile: nil)"

Seems as if that's just some flakiness and not an issue with the PR.

@neonichu
Copy link
Contributor Author

neonichu commented Oct 7, 2020

Please test with following PRs:
swiftlang/sourcekit-lsp#325

@swift-ci please smoke test

@compnerd
Copy link
Member

compnerd commented Oct 8, 2020

@neonichu - can we get this merged? the windows enumerated value is in the version of TSC that LSP is now building against.

@benlangmuir
Copy link
Contributor

Please test with following PRs:
swiftlang/sourcekit-lsp#325

@swift-ci please smoke test

@benlangmuir benlangmuir merged commit 568312f into swiftlang:main Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants