Cleanup Workspace Module #2970
Merged
Cleanup Workspace Module #2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create ResolvedFileWatcher.swift
mattt
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
neonichu
approved these changes
Oct 8, 2020
|
@swift-ci please smoke test |
This doesn't look related, let's re-run. |
|
@swift-ci please smoke test |
abertelrud
approved these changes
Oct 8, 2020
|
@swift-ci please smoke test OS X platform |
|
@swift-ci please smoke test Linux platform |
mattt
added a commit
to mattt/swift-package-manager
that referenced
this pull request
Oct 12, 2020
* Extract ManagedDependency into separate file * Extract ManagedArtifact into separate file * Move declaration of Workspace.DependencyManifests * Move APIs out of misc.swift Create ResolvedFileWatcher.swift * Move ManagedArtifacts and ManagedDependencies declarations * Move declaration of ToolsVersion.zeroedPatch instance method * Move Workspace.DependencyManifests declaration to TSCUtilities Functions extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on the Swift Package Manager client implementation for package registry support (#2967), it took some time for me to understand the functionality of the Workspace module — inn part, because some APIs are declared in places I didn't expect. For example, files often contain declarations or extensions for unrelated types at the end.
This PR extracts some standalone types into separate files and moves other declarations around to be closer to related APIs.
For additional context, these commits were cherry picked from my local development branch. Rather than risk a monolithic, difficult-to-merge PR at the very end of the process, I'd like to take a more incremental approach and break up changes into manageable pieces.