Add Contributing.md #2978
Merged
Add Contributing.md #2978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobucchi
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
federicobucchi
force-pushed
the
fb/add-contributing-md
branch
3 times, most recently
from
1f23267 to
1748933
Compare
federicobucchi
force-pushed
the
fb/add-contributing-md
branch
4 times, most recently
from
a7665f4 to
db38cc7
Compare
|
@swift-ci please smoke test |
tomerd
suggested changes
Oct 16, 2020
tomerd
reviewed
Oct 16, 2020
tomerd
reviewed
Oct 16, 2020
federicobucchi
force-pushed
the
fb/add-contributing-md
branch
2 times, most recently
from
ee6d243 to
e7a6b1f
Compare
|
@swift-ci please smoke test |
tomerd
reviewed
Oct 20, 2020
tomerd
reviewed
Oct 20, 2020
tomerd
reviewed
Oct 20, 2020
tomerd
reviewed
Oct 20, 2020
tomerd
reviewed
Oct 20, 2020
tomerd
reviewed
Oct 20, 2020
tomerd
reviewed
Oct 20, 2020
tomerd
reviewed
Nov 5, 2020
tomerd
reviewed
Nov 5, 2020
tomerd
reviewed
Nov 5, 2020
tomerd
reviewed
Nov 5, 2020
tomerd
reviewed
Nov 5, 2020
tomerd
reviewed
Nov 5, 2020
tomerd
reviewed
Nov 5, 2020
tomerd
reviewed
Nov 5, 2020
federicobucchi
force-pushed
the
fb/add-contributing-md
branch
from
f68fa8d to
3750567
Compare
|
@swift-ci please smoke test |
tomerd
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
tomerd
reviewed
Nov 7, 2020
federicobucchi
force-pushed
the
fb/add-contributing-md
branch
from
3750567 to
b79a92b
Compare
|
@swift-ci please smoke test |
tomerd
reviewed
Nov 9, 2020
tomerd
approved these changes
Nov 9, 2020
|
@swift-ci please smoke test |
|
thank you @federicobucchi |
federicobucchi
added a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
motivation: Quick start contribution guide for Swift Package Manager. Changes: * Add Documentation/Contributing.md * Add SwiftFormat and patch size / number of commits info * Add ISSUE_TEMPLATE.md and PULL_REQUEST_TEMPLATE.md * Consolidate between Contributing.md and the content in https://github.com/apple/swift-package- manager/blob/main/Documentation/Development.md and remove Development.md * Update Contributions section in main README.md * Replace the link for contributing on https://github.com/apple/swift-package-manager#contributions to point to the new Contributing.md rdar://problem/70187482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/70187482
I made a document for quick start contributions for Swift Package Manager that would be great to add and update with time. Initially we could keep Development.md, but at some point we could switch all the way to Contributing.md having 2 “Quick Start” and “Advanced” sections.
First Step (in this PR):
Following Step (future PR):
3) Work on consolidating between Contributing.md and the content in https://github.com/apple/swift-package-manager/blob/main/Documentation/Development.md
4) Remove Development.md