Skip to content

Remove 'try XCTSkip()' from functional tests #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions Tests/FunctionalTests/MiscellaneousTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -213,9 +213,6 @@ class MiscellaneousTestCase: XCTestCase {
}

func testSwiftTestParallel() throws {
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
try XCTSkip()

fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
// First try normal serial testing.
do {
Expand Down Expand Up @@ -261,9 +258,6 @@ class MiscellaneousTestCase: XCTestCase {
}

func testSwiftTestFilter() throws {
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
try XCTSkip()

fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
let (stdout, _) = try SwiftPMProduct.SwiftTest.execute(["--filter", ".*1", "-l", "--enable-test-discovery"], packagePath: prefix)
XCTAssertMatch(stdout, .contains("testExample1"))
Expand All @@ -280,9 +274,6 @@ class MiscellaneousTestCase: XCTestCase {
}

func testSwiftTestSkip() throws {
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
try XCTSkip()

fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
let (stdout, _) = try SwiftPMProduct.SwiftTest.execute(["--skip", "ParallelTestsTests", "-l", "--enable-test-discovery"], packagePath: prefix)
XCTAssertNoMatch(stdout, .contains("testExample1"))
Expand Down Expand Up @@ -423,9 +414,6 @@ class MiscellaneousTestCase: XCTestCase {
}

func testSwiftTestLinuxMainGeneration() throws {
// <rdar://problem/69448176> Fix and re-enable test related to "ParallelTestsPkg"
try XCTSkip()

#if os(macOS)
fixture(name: "Miscellaneous/ParallelTestsPkg") { prefix in
let fs = localFileSystem
Expand Down