Cleanup PackageGraph Module #2992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change BasePackageContainer initializer to internal access
…ontainer.swift Reorder RepositoryPackageContainer declarations
Move nameForDiagnostics helper method into fileprivate extension
Make productFilter public Fix documentation comment for productFilter
Make findCycles fileprivate
mattt
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
neonichu
approved these changes
Oct 21, 2020
abertelrud
approved these changes
Oct 22, 2020
|
@abertelrud @neonichu Actually, one last question: What's the preferred method of merging a PR in this project? Merge commit, squash, or rebase? |
|
Squash is what we commonly use. |
|
Nice. I think that's the right way to go for most PRs, as well. Doing that now. |
federicobucchi
pushed a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
* Extract PackageRequirement into separate file * Extract PackageContainer into separate file * Move BasePackageContainer to PackageContainer file Change BasePackageContainer initializer to internal access * Extract LocalPackageContainer into separate file * Rename RepositoryPackageContainerProvider.swift to RepositoryPackageContainer.swift Reorder RepositoryPackageContainer declarations * Move CheckoutState.requirement to original type declaration * Extract BoundVersion to separate file * Extract DependencyResolutionNode to separate file * Extract GraphLoadingNode to separate file * Move PackageGraphError to PackageGraph declaration * Extract diagnostics concerns to separate file * Rename RawPackageConstraints.swift to PackageModel+Extensions.swift * Refactor PackageGraphLoader functionality into extension on PackageGraph * Extract Pubgrub resolver into separate files * Conform to protocols in extensions * Use built-in Result type * Convert requirement to computed property * Convert nameForDiagnostics into computed property Move nameForDiagnostics helper method into fileprivate extension * Convert productFilter into computed property Make productFilter public Fix documentation comment for productFilter * Remove leading underscore for public property isRemoteContainer * Move PackageReference extension into PackageModel+Extensions * Extract extension on Version into separate file * Make constrained extension on Range fileprivate * Reorganize PinsStore protocol conformance and headings * Move findCycles helper function to PackageGraph+Loading Make findCycles fileprivate * Remove unused delegate APIs for DependencyResolver * Fix CMakeLists source list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another incremental PR working toward an implementation of #2967, this time targeting the PackageGraph module. I'd been holding onto this one, waiting for #2980 was all settled.
This should be the last one of these custodial PRs. Once this is in, I'll have some actual functional additions to share for the package registry.
As always, feel free to push back on any of these if they're at all controversial. These are just some changes that I found to help my own understanding of what's inside PackageGraph, and how these APIs relate to each other.