Fix a recent regression in package identity #3005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…change the semantics), an explicitly provided name in a package dependency is _not_ used as the identity. It is validated against what the package manifest claims, but does not currently constitute the identity. rdar://problem/70764221
abertelrud
requested review from
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
|
Merging, since this is a needed regression fix. The tests pass and this is restoring previous semantics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this point (until we…change the semantics), an explicitly provided name in a package dependency is not used as the identity. It is validated against what the package manifest claims, but does not currently constitute the identity.
re: #2997
rdar://problem/70764221