Ability to write out package manifests as source code (for mechanical package generation) #3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abertelrud
requested review from
aciidgh,
friedbunny and
neonichu
as code owners
abertelrud
commented
Nov 4, 2020
tomerd
reviewed
Nov 7, 2020
abertelrud
force-pushed
the
eng/wip-generate-source-from-package-manifest-for-package-init
branch
from
04dafa1 to
1d82172
Compare
abertelrud
changed the title
|
There are a couple of edge-case FIXMEs to address, then this is ready. |
|
@swift-ci please smoke test |
abertelrud
force-pushed
the
eng/wip-generate-source-from-package-manifest-for-package-init
branch
from
1d82172 to
8006f9c
Compare
|
@swift-ci please smoke test |
abertelrud
force-pushed
the
eng/wip-generate-source-from-package-manifest-for-package-init
branch
from
8006f9c to
6dd5b59
Compare
|
@swift-ci please smoke test |
… flexibility for things like mechanical package manifest generation. Note that this is _not_ suitable for editing the package manifest, since that would need to preserve whitespace and comments. Rather, this is for things like automatically generating packages from test sets, or for generating the initial configuration of packages (e.g. a more flexible `package init`). rdar://70271810
abertelrud
force-pushed
the
eng/wip-generate-source-from-package-manifest-for-package-init
branch
from
6dd5b59 to
9a7301c
Compare
|
@swift-ci please smoke test |
neonichu
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to write out package manifests as source code, providing more flexibility for things like mechanical package manifest generation.
Note that this is not suitable for editing the package manifest, since that would need to preserve whitespace and comments. Rather, this is for things like automatically generating packages from test sets, or for generating the initial configuration of packages (e.g. a more flexible
package init).rdar://70271810