Disable testRepositoryCacheDoesNotDerailResolution
#3046
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests seems to access remote dependencies, we should change it so that it can work without network access. This disables it for now.
neonichu
requested review from
abertelrud,
aciidgh and
friedbunny
as code owners
|
@swift-ci please test |
|
@SDGGiesbrecht could you take a look at changing this test? I missed that this test requires remote dependencies when reviewing #3006 |
tomerd
approved these changes
Nov 13, 2020
abertelrud
approved these changes
Nov 13, 2020
|
I can look into other ways of tripping it. I cannot promise I will find a way though, because the point of the test was that the mocking infrastructure used elsewhere was bypassing the problem entirely. Either way, you may as well outright remove the test instead of just disabling it. If I do find a way, it will look very different. |
|
#3047 has added a new test that replaces this, we can close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests seems to access remote dependencies, we should change it so that it can work without network access. This disables it for now.