remove profile #3068
Merged
remove profile #3068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: reduce complexity changes: remove profile model and update API and storage accordingly
tomerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
This was referenced Nov 19, 2020
yim-lee
approved these changes
Nov 19, 2020
| } | ||
|
|
||
| func testDeleteFromStorageWhenLast() throws { | ||
| func testDeleteFromFromBothStorages() throws { |
There was a problem hiding this comment.
Suggested change
| func testDeleteFromFromBothStorages() throws { | |
| func testDeleteFromBothStorages() throws { |
There was a problem hiding this comment.
will address in #3069 so we dont have to run CI again for one typo
federicobucchi
pushed a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
motivation: reduce complexity changes: remove profile model and update API and storage accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: reduce complexity
changes: remove profile model and update API and storage accordingly