Rename the tags() functions of Repository and of WorkingCheckout to getTags()
#3100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `getTags()`. This makes it more consistent with all the other functions, which have a verb at the start, but more importantly makes it easier for clients to adopt to the change (having a property change to a method without changing name makes it difficult for a type that adopts the protocol to conform to both). No change in functionality.
abertelrud
requested review from
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Dec 9, 2020
federicobucchi
pushed a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
… `getTags()`. This makes it more consistent with all the other functions, which have a verb at the start, but more importantly makes it easier for clients to adopt to the change (having a property change to a method without changing name makes it difficult for a type that adopts the protocol to conform to both). (swiftlang#3100) No change in functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
tags()functions of Repository and of WorkingCheckout togetTags(). Until recently this was a property calledtags, but now that it’s a function it makes more sense to call itgetTags().Motivation:
This makes it more consistent with all the other functions, which have a verb at the start (including the
getCurrentRevision()function), but more importantly this makes it easier for clients to adopt to the change (having a property change to a method without changing name makes it difficult for a type that adopts the protocol to conform to both).Modifications:
Renamed the function in protocols and clients.
Result:
No change in functionality but more consistent naming and easier transition for clients.