clarfiy reveresedVersions/versions in pubgrub #3109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: easier to reason about code changes: * rename PacakgeContainer::reversedVersions to PackageContainer::versionsDescending * add PacakgeContainer::versionsAscending to avoid the versionsDescending().reveresed() code * rename PacakgeContainer::versions(filter) to PackageContainer::toolsVersionsAppropriateVersionsDescending to better reflect the true meaning * remove filter from PackageContainer::toolsVersionsAppropriateVersionsDescending since its not used in practice * adjust tests and mocks
tomerd
force-pushed
the
fix/reversed-versions
branch
from
da1c5f1 to
6cfc566
Compare
|
@swift-ci please smoke test |
neonichu
approved these changes
Dec 11, 2020
abertelrud
approved these changes
Dec 11, 2020
federicobucchi
pushed a commit
to federicobucchi/swift-package-manager
that referenced
this pull request
Jan 6, 2021
motivation: easier to reason about code changes: * rename PacakgeContainer::reversedVersions to PackageContainer::versionsDescending * add PacakgeContainer::versionsAscending to avoid the versionsDescending().reveresed() code * rename PacakgeContainer::versions(filter) to PackageContainer::toolsVersionsAppropriateVersionsDescending to better reflect the true meaning * remove filter from PackageContainer::toolsVersionsAppropriateVersionsDescending since its not used in practice * adjust tests and mocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: easier to reason about code
changes: