Add optional delegate perameter to Workspace.create() #3146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzyzanowskim
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please smoke test |
tomerd
approved these changes
Dec 26, 2020
|
@swift-ci please smoke test macOS Platform |
tomerd
added
the
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional delegate parameter to
Workspace.create()Motivation:
Workspace.createis a convenient way to instantiate aWorkspaceinstance. However can't use it if want to useWorkspaceDelegate- that is unfortunate.Workspace.delegateis aletproperty, hence it can't be set after initialization.Modifications:
Add optional delegate perameter to Workspace.create()
Ref https://bugs.swift.org/browse/SR-4402