Skip to content

Workspace delegate weak property #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Workspace delegate weak property #3148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Sources/Commands/SwiftTool.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ public class SwiftTool {
/// workspace is not needed, infact it would be an error to ask for the workspace object
/// for package init because the Manifest file should *not* present.
private var _workspace: Workspace?
private var _workspaceDelegate: ToolWorkspaceDelegate?

/// Create an instance of this tool.
///
Expand Down Expand Up @@ -514,6 +515,7 @@ public class SwiftTool {
cachePath: try self.getCachePath()
)
_workspace = workspace
_workspaceDelegate = delegate
return workspace
}

Expand Down
2 changes: 1 addition & 1 deletion Sources/Workspace/Workspace.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ private class WorkspaceRepositoryManagerDelegate: RepositoryManagerDelegate {
/// This class does *not* support concurrent operations.
public class Workspace {
/// The delegate interface.
public let delegate: WorkspaceDelegate?
public weak var delegate: WorkspaceDelegate?

/// The path of the workspace data.
public let dataPath: AbsolutePath
Expand Down