Call artifacts download delegate final method #3150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzyzanowskim
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
federicobucchi
approved these changes
Dec 27, 2020
krzyzanowskim
changed the title
|
@swift-ci please smoke test |
|
@krzyzanowskim thanks, I meant the commit message, not only the title in the PR:
|
krzyzanowskim
force-pushed
the
marcin/call-did-download-if-download
branch
from
dd208e6 to
6cc01dd
Compare
|
@federicobucchi sure. pushed. back you you. |
federicobucchi
approved these changes
Dec 28, 2020
abertelrud
approved these changes
Jan 5, 2021
neonichu
approved these changes
Jan 5, 2021
|
@swift-ci please smoke test |
tomerd
added
the
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call atrifacts download delegate final method only if we ever try to download an artifact.
Motivation:
WorkspaceDelegate.didDownloadBinaryArtifactsis called despite there's nothing to download, nor we even tried to download anything. Given the name "did download" it should be called only if there was a download (attempt).Modifications:
Check with flag whether any download happened.